Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dev to match mains ci-cd workflow #49

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Update dev to match mains ci-cd workflow #49

merged 2 commits into from
Oct 16, 2023

Conversation

smalho01
Copy link
Contributor

@smalho01 smalho01 commented Oct 5, 2023

Describe your changes

Updates the ci-cd workflow in this branch to better tag each release accordingly. These updates were also forcefully pushed up into each release branch, which was the easiest way to auto tag each of our releases. Checking docker hub now we have tags from 0.1 to 0.13, latest (main), and experimental (dev). The experimental tag will update once this PR gets merged into dev: https://hub.docker.com/repository/docker/codexrems/pims/tags?page=1&ordering=last_updated

Issue ticket number and Jira link

REMS-491

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

@smalho01
Copy link
Contributor Author

smalho01 commented Oct 5, 2023

note: do not click the update branch button below as that will merge changes from dev into main that we do not want yet - unless we want to make an iterative 0.13.1 release or something similar in which case merging can be performed for that release

@zacharyrobin zacharyrobin self-assigned this Oct 6, 2023
@zacharyrobin zacharyrobin merged commit 6aa368d into dev Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants